Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 435C2200B65 for ; Tue, 2 Aug 2016 20:00:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3FF42160A65; Tue, 2 Aug 2016 18:00:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B67AC160AA8 for ; Tue, 2 Aug 2016 20:00:23 +0200 (CEST) Received: (qmail 37143 invoked by uid 500); 2 Aug 2016 18:00:22 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 37043 invoked by uid 99); 2 Aug 2016 18:00:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 18:00:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A3CB12C0D64 for ; Tue, 2 Aug 2016 18:00:22 +0000 (UTC) Date: Tue, 2 Aug 2016 18:00:22 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-3128) Remove extraneous operations during upsert with local immutable index MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 Aug 2016 18:00:24 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404482#comment-15404482 ] James Taylor commented on PHOENIX-3128: --------------------------------------- Some more info. The DistinctPrefixFilterIT.testDistinct() test only fails for local indexes when DISABLE_WAL is set to true (and the client doesn't send the updates). Looks like there's a hole here, [~rajeshbabu]. > Remove extraneous operations during upsert with local immutable index > --------------------------------------------------------------------- > > Key: PHOENIX-3128 > URL: https://issues.apache.org/jira/browse/PHOENIX-3128 > Project: Phoenix > Issue Type: Bug > Reporter: Junegunn Choi > Assignee: Junegunn Choi > Fix For: 4.8.1 > > Attachments: PHOENIX-3128.patch, PHOENIX-3128_v2.patch, PHOENIX-3128_v3.patch, PHOENIX-3128_v4.patch, PHOENIX-3128_v5.patch, PHOENIX-3128_v6.patch, PHOENIX-3128_v7.patch, PHOENIX-3128_wip.patch > > > Upsert to a table with a local immutable index is supposed to be more efficient than to a table with a local mutable index, but it's actually slower (in our environment by 30%) due to extraneous operations involved. > The problem is twofold: > 1. Client unnecessarily prepares and sends index update. > 2. Index cleanup is done regardless of the immutability of the table. -- This message was sent by Atlassian JIRA (v6.3.4#6332)