Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 27666200B64 for ; Tue, 2 Aug 2016 09:18:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 260B6160A8C; Tue, 2 Aug 2016 07:18:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6CB8F160A76 for ; Tue, 2 Aug 2016 09:18:23 +0200 (CEST) Received: (qmail 49434 invoked by uid 500); 2 Aug 2016 07:18:22 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 49423 invoked by uid 99); 2 Aug 2016 07:18:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 07:18:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 212711A12D4 for ; Tue, 2 Aug 2016 07:18:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 0lJdYIgMwMHm for ; Tue, 2 Aug 2016 07:18:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 0C4475FB00 for ; Tue, 2 Aug 2016 07:18:20 +0000 (UTC) Received: (qmail 49404 invoked by uid 99); 2 Aug 2016 07:18:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 07:18:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 75C0B2C0059 for ; Tue, 2 Aug 2016 07:18:20 +0000 (UTC) Date: Tue, 2 Aug 2016 07:18:20 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-3128) Remove extraneous operations during upsert with local immutable index MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 Aug 2016 07:18:24 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-3128: ---------------------------------- Attachment: PHOENIX-3128_v6.patch Please review, [~rajeshbabu]. Other than for initial local index build, I don't believe there's any mechanism in place that generates the server-side updates for incremental index maintenance. So the first of the "extraneous operation" is actually required. [~ankit@apache.org] - if this passes all tests and [~rajeshbabu] thinks it's fine, then we can commit this for 4.8.0. Otherwise, we can wait. Would be good to get a new RC up either way, though. > Remove extraneous operations during upsert with local immutable index > --------------------------------------------------------------------- > > Key: PHOENIX-3128 > URL: https://issues.apache.org/jira/browse/PHOENIX-3128 > Project: Phoenix > Issue Type: Bug > Reporter: Junegunn Choi > Assignee: Junegunn Choi > Fix For: 4.8.1 > > Attachments: PHOENIX-3128.patch, PHOENIX-3128_v2.patch, PHOENIX-3128_v3.patch, PHOENIX-3128_v4.patch, PHOENIX-3128_v5.patch, PHOENIX-3128_v6.patch, PHOENIX-3128_wip.patch > > > Upsert to a table with a local immutable index is supposed to be more efficient than to a table with a local mutable index, but it's actually slower (in our environment by 30%) due to extraneous operations involved. > The problem is twofold: > 1. Client unnecessarily prepares and sends index update. > 2. Index cleanup is done regardless of the immutability of the table. -- This message was sent by Atlassian JIRA (v6.3.4#6332)