Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: joshelser <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-186-phoenix@git.apache.org>
In-Reply-To: <git-pr-186-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #186: cleanup sqlline*.py using python idioms.
Content-Type: text/plain
Message-Id: <20160812155054.0D19FDFE2E@git1-us-west.apache.org>
Date: Fri, 12 Aug 2016 15:50:54 +0000 (UTC)
archived-at: Fri, 12 Aug 2016 15:50:56 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/186#discussion_r74614217
  
    --- Diff: bin/sqlline.py ---
    @@ -1,4 +1,5 @@
     #!/usr/bin/env python
    +"""sqlline.py"""
    --- End diff --
    
    Is this a convention I don't know about? From a licensing perspective, I think it would be best to make sure the ASLv2 header be the first thing after the shebang.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---