Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: btbytes <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-186-phoenix@git.apache.org>
In-Reply-To: <git-pr-186-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #186: cleanup sqlline-thin.py using python idioms.
Content-Type: text/plain
Message-Id: <20160801184215.C24DEE058E@git1-us-west.apache.org>
Date: Mon,  1 Aug 2016 18:42:15 +0000 (UTC)
archived-at: Mon, 01 Aug 2016 18:42:17 -0000

Github user btbytes commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/186#discussion_r73030368
  
    --- Diff: bin/sqlline-thin.py ---
    @@ -18,64 +18,58 @@
     # limitations under the License.
     #
     ############################################################################
    -
    +from __future__ import print_function
     import os
    +import phoenix_utils
     import subprocess
     import sys
    -import phoenix_utils
    -import atexit
     import urlparse
     
    -global childProc
    -childProc = None
    -def kill_child():
    -    if childProc is not None:
    -        childProc.terminate()
    -        childProc.kill()
    -        if os.name != 'nt':
    -            os.system("reset")
    -atexit.register(kill_child)
    --- End diff --
    
    I take half of that back. `childProc` is being used in `sqlline.py`, not in this script. I'll see if I can take care of zombie child processes in a cleaner way in both places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---