From dev-return-33050-apmail-phoenix-dev-archive=phoenix.apache.org@phoenix.apache.org Wed Aug 10 19:22:52 2016 Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0B6A19D8B for ; Wed, 10 Aug 2016 19:22:51 +0000 (UTC) Received: (qmail 43683 invoked by uid 500); 10 Aug 2016 19:22:51 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 43632 invoked by uid 500); 10 Aug 2016 19:22:51 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 43621 invoked by uid 99); 10 Aug 2016 19:22:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2016 19:22:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4E23AE00A7; Wed, 10 Aug 2016 19:22:51 +0000 (UTC) From: samarthjain To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request #189: PHOENIX-3036 Modify phoenix IT tests to extend Ba... Content-Type: text/plain Message-Id: <20160810192251.4E23AE00A7@git1-us-west.apache.org> Date: Wed, 10 Aug 2016 19:22:51 +0000 (UTC) Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/189#discussion_r74312374 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java --- @@ -1066,7 +1065,7 @@ public void testAddPKColumn() throws Exception { public void testDropKVColumn() throws Exception { long ts = nextTimestamp(); String tenantId = getOrganizationId(); - initATableValues(tenantId, getDefaultSplits(tenantId), null, ts); + initATableValues("aTable", tenantId, getDefaultSplits(tenantId), null, ts, getUrl()); --- End diff -- Use static constant for "aTable" in BaseTest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---