phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3136) Relocation of Avatica classes breaks compatibilty between older version of thin-client/PQS
Date Tue, 02 Aug 2016 17:27:20 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404432#comment-15404432
] 

Hadoop QA commented on PHOENIX-3136:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12821641/PHOENIX-3136.001.patch
  against master branch at commit 545cc1c025ec56ef174f117f8d96212457f96363.
  ATTACHMENT ID: 12821641

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 34 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/491//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/491//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/491//console

This message is automatically generated.

> Relocation of Avatica classes breaks compatibilty between older version of thin-client/PQS
> ------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3136
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3136
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-3136.001.patch
>
>
> It was recently brought to my attention by [~holman.lan0@gmail.com] that the shading
change will break all previous versions of the thin client from working with the newer PQS
(and vice versa).
> Avatica uses the full class name in the message to identify what protobuf message to
use to deserialize the bytes from the wire. As such, an older thin client would be expecting
these protobuf classes to look like {{org.apache.calcite.avatica.proto.Responses$PrepareResponse}}.
However after PHOENIX-2535, PQS would be sending back {{org.apache.phoenix.shaded.org.apache.calcite.avatica.proto.Responses$PrepareResponse}}.
Both are trying to refer to the same Java class, but we can't disambiguate presently.
> Long term, I think the protocol itself will have to be updated in Avatica to be a little
less brittle in this regard (I did not originally consider the implications that client/server
might *have* the classes, but with a different name than what we had in Avatica).
> Short term, we can undo the relocation of the Avatica classes in the thin-client and
queryserver artifacts. I will be working on this post-haste. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message