phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3132) cleanup sqlline-*.py using python idioms
Date Mon, 01 Aug 2016 17:29:20 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402459#comment-15402459
] 

ASF GitHub Bot commented on PHOENIX-3132:
-----------------------------------------

Github user btbytes commented on the issue:

    https://github.com/apache/phoenix/pull/186
  
    1. Issue - https://issues.apache.org/jira/browse/PHOENIX-3132
    2. I was waiting for a response do this PR before I took on more refactoring ;) 
    3. I have tested in so far as the output of the two versions of the program are the same
before they are shelled out in the last line. So, yes.


> cleanup sqlline-*.py using python idioms
> ----------------------------------------
>
>                 Key: PHOENIX-3132
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3132
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Pradeep Gowda
>
> Cleanup the Python program(s) to:
> 1. easier to read and modify
> 2. remove unused code and variables.
> 3. use string `format` instead of concating string using `+`s
> 4. ... and other proper Python idioms



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message