phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3036) Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
Date Mon, 15 Aug 2016 21:46:20 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421732#comment-15421732
] 

ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74841351
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SkipScanAfterManualSplitIT.java
---
    @@ -43,7 +43,7 @@
     import com.google.common.collect.Maps;
     
     
    -public class SkipScanAfterManualSplitIT extends BaseHBaseManagedTimeIT {
    +public class SkipScanAfterManualSplitIT extends BaseHBaseManagedTimeTableReuseIT {
    --- End diff --
    
    I think table names can be randomized here. I would also get rid of tableName and tableNameBytes
static constants.


> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3036
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: prakul agarwal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3036.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message