phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3036) Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
Date Fri, 12 Aug 2016 19:51:20 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419353#comment-15419353
] 

ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74650871
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/DropMetadataIT.java
---
    @@ -84,14 +77,17 @@ public static void doSetup() throws Exception {
         @Test
         public void testDropViewKeepsHTable() throws Exception {
             HBaseAdmin admin = driver.getConnectionQueryServices(getUrl(), TEST_PROPERTIES).getAdmin();
    +        String hbaseNativeViewName = generateRandomString();
    +
    +        byte[] hbaseNativeBytes = SchemaUtil.getTableNameAsBytes(HBASE_NATIVE_SCHEMA_NAME,
hbaseNativeViewName);
             try {
                 try {
    -                admin.disableTable(HBASE_NATIVE_BYTES);
    -                admin.deleteTable(HBASE_NATIVE_BYTES);
    +                admin.disableTable(hbaseNativeBytes);
    --- End diff --
    
    No need to disable and delete table since you the name is random.


> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3036
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: prakul agarwal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3036.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message