phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3036) Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
Date Wed, 10 Aug 2016 19:00:23 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415787#comment-15415787
] 

ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74308491
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DateTimeIT.java ---
    @@ -57,12 +44,13 @@
     import org.junit.Test;
     
     
    -public class DateTimeIT extends BaseHBaseManagedTimeIT {
    +public class DateTimeIT extends BaseHBaseManagedTimeTableReuseIT {
     
         protected Connection conn;
         protected Date date;
         protected static final String tenantId = getOrganizationId();
         protected final static String ROW10 = "00D123122312312";
    +    protected  String tableName;
    --- End diff --
    
    Don't have tableName as a member variable. Instead each test case can create their own
table. This will be critical once we decide on parallelizing test methods within a test class.



> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3036
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: prakul agarwal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3036.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message