phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3036) Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
Date Wed, 10 Aug 2016 18:53:20 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415779#comment-15415779
] 

ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74307236
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CSVCommonsLoaderIT.java
---
    @@ -45,15 +45,15 @@
     import org.apache.phoenix.util.PhoenixRuntime;
     import org.junit.Test;
     
    -public class CSVCommonsLoaderIT extends BaseHBaseManagedTimeIT {
    +public class CSVCommonsLoaderIT extends BaseHBaseManagedTimeTableReuseIT {
     
         private static final String DATATYPE_TABLE = "DATATYPE";
         private static final String DATATYPES_CSV_VALUES = "CKEY, CVARCHAR, CCHAR, CINTEGER,
CDECIMAL, CUNSIGNED_INT, CBOOLEAN, CBIGINT, CUNSIGNED_LONG, CTIME, CDATE\n"
                 + "KEY1,A,A,2147483647,1.1,0,TRUE,9223372036854775807,0,1990-12-31 10:59:59,1999-12-31
23:59:59\n"
                 + "KEY2,B,B,-2147483648,-1.1,2147483647,FALSE,-9223372036854775808,9223372036854775807,2000-01-01
00:00:01,2012-02-29 23:59:59\n"
                 + "KEY3,,,,,,,,,,\n";
    -    private static final String STOCK_TABLE = "STOCK_SYMBOL";
    -    private static final String STOCK_TABLE_MULTI = "STOCK_SYMBOL_MULTI";
    +    //private static final String stockTableName = "STOCK_SYMBOL";
    --- End diff --
    
    remove commented code.


> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3036
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: prakul agarwal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3036.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message