phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samarthjain <...@git.apache.org>
Subject [GitHub] phoenix pull request #189: PHOENIX-3036 Modify phoenix IT tests to extend Ba...
Date Wed, 10 Aug 2016 21:35:32 GMT
Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74335513
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SpooledTmpFileDeleteIT.java
---
    @@ -38,11 +38,12 @@
     
     
     
    -public class SpooledTmpFileDeleteIT extends BaseHBaseManagedTimeIT {
    +public class SpooledTmpFileDeleteIT extends BaseHBaseManagedTimeTableReuseIT {
     	
         private Connection conn = null;
         private Properties props = null;
         private File spoolDir;
    +	private String tableName;
    --- End diff --
    
    No table names in member variables, please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message