phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samarthjain <...@git.apache.org>
Subject [GitHub] phoenix pull request #189: PHOENIX-3036 Modify phoenix IT tests to extend Ba...
Date Wed, 10 Aug 2016 19:21:50 GMT
Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74312230
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixRuntimeIT.java ---
    @@ -95,53 +96,62 @@ private static Filter getUserTableAndViewsFilter() {
         }
         
         private void testGetTenantIdExpression(boolean isSalted) throws Exception {
    +        //Have to metaData tables because BaseHBaseManagedTimeTableReuseIT doesn't delete
them after each test case , and tenant list will create issues between test cases
    +        deletePriorMetaData(HConstants.LATEST_TIMESTAMP, getUrl());
    --- End diff --
    
    Do we need this if we randomly generate the tenantIds? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message