phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From btbytes <...@git.apache.org>
Subject [GitHub] phoenix pull request #186: cleanup sqlline-thin.py using python idioms.
Date Mon, 01 Aug 2016 18:33:46 GMT
Github user btbytes commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/186#discussion_r73028883
  
    --- Diff: bin/sqlline-thin.py ---
    @@ -18,64 +18,58 @@
     # limitations under the License.
     #
     ############################################################################
    -
    +from __future__ import print_function
     import os
    +import phoenix_utils
     import subprocess
     import sys
    -import phoenix_utils
    -import atexit
     import urlparse
     
    -global childProc
    -childProc = None
    -def kill_child():
    -    if childProc is not None:
    -        childProc.terminate()
    -        childProc.kill()
    -        if os.name != 'nt':
    -            os.system("reset")
    -atexit.register(kill_child)
    --- End diff --
    
    AFAICT, that variable was not altered anywhere after the initialisation. I grepped across
the project (ugh.. globals) and did not see it changed it anywhere else either. 
    
    IMO, this is a copy-paste artifact?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message