phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix issue #186: cleanup sqlline-thin.py using python idioms.
Date Mon, 01 Aug 2016 18:32:05 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/186
  
    > quite a bit of this script is to poke the environment .. which is I/O. Unit testing
may not yield much. But, i'll take a fresh look. 
    
    Yeah, I can understand where you're coming from. It would probably require some indirection
to do it well. One concrete example I saw again was that we use JAVA_HOME from the environment
unless it exists in the `hbase-env.*` script. These are the sorts of things that stand out
at me that, long term, we should have tests to prove work as expected.
    
    Again, I don't want to push them all on you in this changeset, but I'd be more than happy
to work with someone who is a better python dev than myself :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message