phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix issue #186: cleanup sqlline-thin.py using python idioms.
Date Mon, 01 Aug 2016 18:17:52 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/186
  
    Left a few comments for you inline. Overall, I like the changes. Would love to see corresponding
ones made for sqlline.py initially (we tend to make changes to one in the other as well).
I don't think we would need to revisit all of the scripts for the first round (unless you're
up to the task!).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message