phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix issue #186: cleanup sqlline-thin.py using python idioms.
Date Mon, 01 Aug 2016 16:31:55 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/186
  
    Hi @btbytes! Thanks for the changes so far. A couple of things:
    
    1. Have you opened a JIRA issue which captures the changes you'd like to make? We want
to make sure that JIRA is the source system of record for discussing changes. You should be
able to create an "Improvement" issue under https://issues.apache.org/jira/browse/PHOENIX.
If you haven't already, please do so, and then let me know the URL and I can assign it to
you to for credit.
    2. Any thoughts about making the corresponding changes to sqlline.py that you made here
to sqlline-thin.py?
    3. Any thoughts about testing these changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message