Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Mon, 25 Jul 2016 19:39:20 +0000 (UTC)
From: "Loknath Priyatham Teja Singamsetty  (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12992217.1469441751000.126736.1469475560567@Atlassian.JIRA>
In-Reply-To: <JIRA.12992217.1469441751000@Atlassian.JIRA>
References: <JIRA.12992217.1469441751000@Atlassian.JIRA> <JIRA.12992217.1469441751202@arcas>
Subject: [jira] [Comment Edited] (PHOENIX-3113) Automatic build of async
 index will happen even if mapreduce.framework.name is not set in any
 configuration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 25 Jul 2016 19:39:25 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392546#comment-15392546 ] 

Loknath Priyatham Teja Singamsetty  edited comment on PHOENIX-3113 at 7/25/16 7:39 PM:
---------------------------------------------------------------------------------------

[~tdsilva] Attached patch. Please run the AsyncIndexIT.java unit test before pushing the changes in. I couldn't test the working as the https://repository.apache.org/ is down resulting in mvn build failures.


was (Author: singamteja):
[~tdsilva] Attached patch.

> Automatic build of async index will happen even if mapreduce.framework.name is not set in any configuration
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3113
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3113
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Assignee: Loknath Priyatham Teja Singamsetty 
>            Priority: Blocker
>             Fix For: 4.8.0
>
>         Attachments: phoenix-3113.patch
>
>
> As per below code, we are starting automatic build of async index even if mapreduce.framework.name is not set in any of the configuration(because conf.get(QueryServices.MAPRED_FRAMEWORK_NAME) will always return LOCAL as a default value).
> This may cause problem in the hbase cluster where mapreduce is not deployed or this configuration is not set or included in the classpath. 
> {code}
> String hbaseClusterDistributedMode = conf.get(QueryServices.HBASE_CLUSTER_DISTRIBUTED_ATTRIB);
>         String mapredFrameworkName = conf.get(QueryServices.MAPRED_FRAMEWORK_NAME);
> if ((hbaseClusterDistributedMode != null && !hbaseClusterDistributedMode.equals(HBASE_CLUSTER_DISTRIBUTED_CONFIG)) || 
>             (mapredFrameworkName != null && !mapredFrameworkName.equals(MAPRED_FRAMEWORK_YARN_CONFIG)))
>         {
>             LOG.info("Enabling Async Index rebuilder");
>             AsyncIndexRebuilderTask asyncIndexRebuilderTask = new AsyncIndexRebuilderTask(e.getEnvironment());
>             // run async index rebuilder task every 10 secs to rebuild any newly created async indexes
>             executor.scheduleAtFixedRate(asyncIndexRebuilderTask, 10000, rebuildIndexTimeInterval, TimeUnit.MILLISECONDS);
>         }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)