Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F02BA200ACA for ; Thu, 9 Jun 2016 20:57:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EEC07160A58; Thu, 9 Jun 2016 18:57:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 43221160A29 for ; Thu, 9 Jun 2016 20:57:24 +0200 (CEST) Received: (qmail 84883 invoked by uid 500); 9 Jun 2016 18:57:23 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 84872 invoked by uid 99); 9 Jun 2016 18:57:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 18:57:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0B9411805A8 for ; Thu, 9 Jun 2016 18:57:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id IdkvVsC9W9n1 for ; Thu, 9 Jun 2016 18:57:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id EB2E55F22F for ; Thu, 9 Jun 2016 18:57:21 +0000 (UTC) Received: (qmail 83465 invoked by uid 99); 9 Jun 2016 18:57:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 18:57:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3220D2C1F60 for ; Thu, 9 Jun 2016 18:57:21 +0000 (UTC) Date: Thu, 9 Jun 2016 18:57:21 +0000 (UTC) From: "Samarth Jain (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-2901) If namespaces are enabled, check for existence of schema when sequence created MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 09 Jun 2016 18:57:25 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323120#comment-15323120 ] Samarth Jain commented on PHOENIX-2901: --------------------------------------- Thanks [~ankit@apache.org]. Patch looks good to me then! +1 > If namespaces are enabled, check for existence of schema when sequence created > ------------------------------------------------------------------------------ > > Key: PHOENIX-2901 > URL: https://issues.apache.org/jira/browse/PHOENIX-2901 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.8.0 > Reporter: James Taylor > Assignee: Ankit Singhal > Fix For: 4.8.0 > > Attachments: PHOENIX-2901.patch, PHOENIX-2901_v2.patch, PHOENIX-2901_withMoreTestCases.patch > > > If namespaces are enabled, we should check for the existence of the sequence schema before creating the sequence. There are some sequences that are generated by Phoenix to manage indexes over views which auto generate a schema name. Perhaps it'd be better if those used the SYSTEM schema instead and prepended the sequence name with the previous schema name to ensure uniqueness. -- This message was sent by Atlassian JIRA (v6.3.4#6332)