phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2968) Minimize RPCs for ALTER statement over APPEND_ONLY_SCHEMA
Date Thu, 09 Jun 2016 21:26:21 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323391#comment-15323391
] 

James Taylor commented on PHOENIX-2968:
---------------------------------------

If I understand this correctly, we are still making an RPC when an ALTER statement is run
over a table with APPEND_ONLY_SCHEMA = true. This should not be necessary - we should be able
to move the code in MetaDataClient.createTable() to MetaDataClient.addColumn() and simply
always call it when APPEND_ONLY_SCHEMA is set to true so we get the reduced RPC benefit for
both CREATE TABLE and ALTER TABLE or ALTER VIEW.

> Minimize RPCs for ALTER statement over APPEND_ONLY_SCHEMA
> ---------------------------------------------------------
>
>                 Key: PHOENIX-2968
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2968
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Mujtaba Chohan
>            Assignee: James Taylor
>              Labels: Argus
>             Fix For: 4.9.0
>
>
> View is created with {{CREATE VIEW IF NOT EXISTS ... APPEND_ONLY_SCHEMA = true, UPDATE_CACHE_FREQUENCY=900000}}

> If {{ALTER VIEW <VIEW_NAME> ADD IF NOT EXISTS MYCOL VARCHAR}} is executed before
each upsert statement then performance for each 1K batch upsert degrades by ~40X (50ms for
1K batch without alter statement vs 2300ms with alter statement)
> This is for the case when MYCOL exists. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message