phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf
Date Tue, 21 Jun 2016 21:18:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342729#comment-15342729
] 

Enis Soztutar edited comment on PHOENIX-2931 at 6/21/16 9:18 PM:
-----------------------------------------------------------------

Please remove System.out.println() statements. 

Why {{jdbc:phoenix:null}} and {{jdbc:phoenix;test=true}}? 

getDefaultConnectionString() does not seem to belong in HBaseFactoryProvider. 

For below: 
{code}
+                    execCmd.connectionString = arg;
+                    j = i;
..
+            if (j > 0) {
+                usageError("Connection string to HBase must be supplied before input files",
options);
             }
{code}
You can just do a much simpler thing:
{code}
 if (i ==0) {
  execCmd.connectionString = arg;
 } else {
  usageError("Don't know how to interpret argument '" + arg + "'", options);
}
{code}

Tests work with the changes? PhoenixEmbeddedDriverTest.testNegativeGetConnectionInfo() needs
to be changed? 


was (Author: enis):
Please remove System.out.println() statements. 

Why {{jdbc:phoenix:null}} and {{jdbc:phoenix;test=true}}? 

getDefaultConnectionString() does not seem to belong in HBaseFactoryProvider. 

For below: 
{code}
+                    execCmd.connectionString = arg;
+                    j = i;
..
+            if (j > 0) {
+                usageError("Connection string to HBase must be supplied before input files",
options);
             }
{code}
You can just do a much simpler thing:
{code}
 if (i ==0) {
  execCmd.connectionString = arg;
 } else {
  usageError("Don't know how to interpret argument '" + arg + "'", options);
}

Tests work with the changes? PhoenixEmbeddedDriverTest.testNegativeGetConnectionInfo() needs
to be changed? 

> Phoenix client asks users to provide configs in cli that are present on the machine in
hbase conf
> -------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2931
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2931
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Alicia Ying Shu
>            Assignee: Alicia Ying Shu
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2931-v1.patch, PHOENIX-2931-v2.patch, PHOENIX-2931.patch
>
>
> Users had complaints on running commands like
> {code}
> phoenix-sqlline pre-prod-poc-2.novalocal,pre-prod-poc-10.novalocal,pre-prod-poc-1.novalocal:/hbase-unsecure
service-logs.sql
> {code}
> However the zookeeper quorum and the port are available in hbase configs. Phoenix should
read these configs from the system instead of having the user supply them every time.
> What we can do is to introduce a keyword "default". If it is specified, default zookeeper
quorum and port will be taken from hbase configs. Otherwise, users can specify their own.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message