phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...
Date Tue, 10 May 2016 15:41:09 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/168#discussion_r62696240
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
    @@ -187,13 +186,13 @@ public void initTable() throws Exception {
                     "CREATE LOCAL INDEX \"idx_supplier\" ON " + JOIN_SUPPLIER_TABLE_FULL_NAME
+ " (name)"
                     }, {
                     "SORT-MERGE-JOIN (LEFT) TABLES\n" +
    -                "    CLIENT PARALLEL 1-WAY RANGE SCAN OVER " + MetaDataUtil.LOCAL_INDEX_TABLE_PREFIX
+ JOIN_SUPPLIER_TABLE_DISPLAY_NAME + " [-32768]\n" +
    +                "    CLIENT PARALLEL 1-WAY RANGE SCAN OVER " +JOIN_SUPPLIER_TABLE_DISPLAY_NAME
+ " [1]\n" +
    --- End diff --
    
    We should update the explain plan code to output something else when a local index is
used, otherwise it's too difficult to tell. Is the local index being used?
    
    Something like ... OVER LOCAL INDEX <index name> ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message