Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8AC9718F23 for ; Tue, 19 Apr 2016 00:53:28 +0000 (UTC) Received: (qmail 77020 invoked by uid 500); 19 Apr 2016 00:53:28 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 76955 invoked by uid 500); 19 Apr 2016 00:53:28 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 76943 invoked by uid 99); 19 Apr 2016 00:53:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 00:53:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EE274C21C8 for ; Tue, 19 Apr 2016 00:53:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.216 X-Spam-Level: X-Spam-Status: No, score=-4.216 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.996] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id D7s6I0iXWokF for ; Tue, 19 Apr 2016 00:53:27 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 7711C5F243 for ; Tue, 19 Apr 2016 00:53:26 +0000 (UTC) Received: (qmail 76929 invoked by uid 99); 19 Apr 2016 00:53:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 00:53:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9163C2C1F60 for ; Tue, 19 Apr 2016 00:53:25 +0000 (UTC) Date: Tue, 19 Apr 2016 00:53:25 +0000 (UTC) From: "Samarth Jain (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (PHOENIX-2842) Queries with offset shouldn't be using Spooling and chunked result iterators MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain reassigned PHOENIX-2842: ------------------------------------- Assignee: Samarth Jain (was: Ankit Singhal) > Queries with offset shouldn't be using Spooling and chunked result iterators > ---------------------------------------------------------------------------- > > Key: PHOENIX-2842 > URL: https://issues.apache.org/jira/browse/PHOENIX-2842 > Project: Phoenix > Issue Type: Bug > Reporter: Samarth Jain > Assignee: Samarth Jain > > While reworking our serial queries for PHOENIX-2724, I noticed that queries with offset are always using SpoolingResultIterator and ChunkedResultIterator when there is no non-row key order by. > In ScanPlan.java > {code} > private static ParallelIteratorFactory buildResultIteratorFactory(StatementContext context, FilterableStatement statement, > TableRef table, OrderBy orderBy, Integer limit,Integer offset, boolean allowPageFilter) throws SQLException { > if ((isSerial(context, statement, table, orderBy, limit, offset, allowPageFilter) > || ScanUtil.isRoundRobinPossible(orderBy, context) || ScanUtil.isPacingScannersPossible(context)) > && *offset == null*) { return ParallelIteratorFactory.NOOP_FACTORY; } > {code} > Spooling and chunking is deprecated. So the code shouldn't be relying on them to be used always. Removing the offset != null check, unfortunately causes tests to fail in QueryWithOffsetIT.java. This is because if we don't create chunked result iterators, server side scanners are not getting advanced up to the offset. > [~ankit.singhal] - can you please check? -- This message was sent by Atlassian JIRA (v6.3.4#6332)