Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Tue, 5 Apr 2016 18:48:25 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12955637.1459704743000.141554.1459882105508@Atlassian.JIRA>
In-Reply-To: <JIRA.12955637.1459704743000@Atlassian.JIRA>
References: <JIRA.12955637.1459704743000@Atlassian.JIRA>
 <JIRA.12955637.1459704743138@arcas>
Subject: [jira] [Commented] (PHOENIX-2819) Remove problematic method
 ValueSchemaBuilder.addField(Field)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PHOENIX-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226906#comment-15226906 ] 

Hudson commented on PHOENIX-2819:
---------------------------------

SUCCESS: Integrated in Phoenix-master #1183 (See [https://builds.apache.org/job/Phoenix-master/1183/])
PHOENIX-2819 Remove problematic method (maryannxue: rev 3420a973c3fbe5ee4483216e54596869665c7cc9)
* phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java
* phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/ValueSchema.java


> Remove problematic method ValueSchemaBuilder.addField(Field)
> ------------------------------------------------------------
>
>                 Key: PHOENIX-2819
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2819
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.7.0
>            Reporter: Maryann Xue
>            Assignee: Maryann Xue
>              Labels: secondary_index
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2819-2.patch, PHOENIX-2819.patch
>
>
> We should discard the method "ValueSchemaBuilder.addField(Field)" and use the other method signature instead, since this method might add more fields than wanted.
> {code}
>         public ValueSchemaBuilder addField(Field field) {
>             fields.add(field);
>             return this;
>         }
> {code}
> If {{field.size}} is larger than 1, the above statement {{fields.add(field)}} will add more than one field into the list while the caller is expecting to add only ONE.
> The only caller of this method is IndexMaintainer.generateIndexRowKeySchema() and it might generate a wrong row-key-schema as a result.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)