Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Tue, 5 Apr 2016 00:08:25 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12945363.1456729609000.132779.1459814905532@Atlassian.JIRA>
In-Reply-To: <JIRA.12945363.1456729609000@Atlassian.JIRA>
References: <JIRA.12945363.1456729609000@Atlassian.JIRA>
 <JIRA.12945363.1456729609794@arcas>
Subject: [jira] [Commented] (PHOENIX-2722) support mysql "limit,offset"
 clauses
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/PHOENIX-2722?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15=
225343#comment-15225343 ]=20

ASF GitHub Bot commented on PHOENIX-2722:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r58469617
 =20
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryCons=
tants.java ---
    @@ -138,6 +138,9 @@
         public final static String SYSTEM_SCHEMA_NAME =3D "SYSTEM";
         public final static byte[] SYSTEM_SCHEMA_NAME_BYTES =3D Bytes.toBy=
tes(SYSTEM_SCHEMA_NAME);
         public final static String PHOENIX_METADATA =3D "table";
    +    public final static String OFFSET =3D "offset";
    +    public final static byte[] offsetRowKeyBytes =3D "_OFFSET_".getByt=
es();
    --- End diff --
   =20
    Nit: use Bytes.toBytes(OFFSET) instead. Also, did you want it to be "_O=
FFSET_" for the OFFSET constant?


> support mysql "limit,offset" clauses=20
> -------------------------------------
>
>                 Key: PHOENIX-2722
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2722
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Minor
>         Attachments: PHOENIX-2722.patch, PHOENIX-2722_formatted.patch
>
>
> For serial query(query with =E2=80=9Cserial" hint or  =E2=80=9Climit" wit=
hout "order by=E2=80=9D), we can limit each scan(using page filter) to =E2=
=80=9Climit+offset=E2=80=9D instead of limit earlier.
> And then, for all queries, we can forward the relevant client iterators t=
o the offset provided and then return the result.
> syntax
> {code}
> [ LIMIT { count } ]
>     [ OFFSET start [ ROW | ROWS ] ]
>     [ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
> {code}
> Some new keywords(OFFSET,FETCH,ROW, ROWS,ONLY) are getting introduced so =
users might need to see that they are not using them as column name or some=
thing.
> WDYT, [~jamestaylor]


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)