Return-Path: 
 <dev-return-28116-apmail-phoenix-dev-archive=phoenix.apache.org@phoenix.apache.org>
X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org
Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 0EA02197E3
	for <apmail-phoenix-dev-archive@minotaur.apache.org>;
 Tue,  5 Apr 2016 03:08:34 +0000 (UTC)
Received: (qmail 21432 invoked by uid 500); 5 Apr 2016 03:08:28 -0000
Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org
Received: (qmail 21371 invoked by uid 500); 5 Apr 2016 03:08:28 -0000
Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@phoenix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@phoenix.apache.org>
List-Post: <mailto:dev@phoenix.apache.org>
List-Id: <dev.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list dev@phoenix.apache.org
Received: (qmail 21360 invoked by uid 99); 5 Apr 2016 03:08:28 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO
 spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 03:08:28 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org)
 with ESMTP id 294461A467B
	for <dev@phoenix.apache.org>; Tue,  5 Apr 2016 03:08:28 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -3.221
X-Spam-Level: 
X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31
	tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1,
	RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx2-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new,
 port 10024)
	with ESMTP id R1YQoJFYFfb8 for <dev@phoenix.apache.org>;
	Tue,  5 Apr 2016 03:08:27 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP
 id 7586F5F2C3
	for <dev@phoenix.incubator.apache.org>; Tue,  5 Apr 2016 03:08:26 +0000 (UTC)
Received: (qmail 20810 invoked by uid 99); 5 Apr 2016 03:08:25 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 03:08:25 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 759A32C14E1
	for <dev@phoenix.incubator.apache.org>; Tue,  5 Apr 2016 03:08:25 +0000 (UTC)
Date: Tue, 5 Apr 2016 03:08:25 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12933918.1453751046000.134239.1459825705477@Atlassian.JIRA>
In-Reply-To: <JIRA.12933918.1453751046000@Atlassian.JIRA>
References: <JIRA.12933918.1453751046000@Atlassian.JIRA>
 <JIRA.12933918.1453751046619@arcas>
Subject: [jira] [Commented] (PHOENIX-2628) Ensure split when iterating
 through results handled correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225574#comment-15225574 ] 

ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58481362
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java ---
    @@ -337,6 +384,22 @@ public boolean nextRaw(List<Cell> result) throws IOException {
                             arrayElementCell = result.get(arrayElementCellPosition);
                         }
                         if (ScanUtil.isLocalIndex(scan) && !ScanUtil.isAnalyzeTable(scan)) {
    +                        if(hasReferences && actualStartKey!=null) {
    +                            Cell firstCell = result.get(0);
    +                            while(Bytes.compareTo(firstCell.getRowArray(), firstCell.getRowOffset(), firstCell.getRowLength(), actualStartKey, 0, actualStartKey.length)<0) {
    +                                result.clear();
    +                                next = s.nextRaw(result);
    +                                if (result.isEmpty()) {
    +                                    return next;
    +                                }
    +                                if (arrayFuncRefs != null && arrayFuncRefs.length > 0 && arrayKVRefs.size() > 0) {
    +                                    replaceArrayIndexElement(arrayKVRefs, arrayFuncRefs, result);
    +                                }
    +                                firstCell = result.get(0);
    +                            }
    +                        }
    +                        System.out.println("&&&&-< "+scan);
    +                        System.out.println("&&&&-<< "+result);
    --- End diff --
    
    Remove System.out.println calls


> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
>                 Key: PHOENIX-2628
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2628
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch, PHOENIX-2628_v7.patch, PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for scans and aggregates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)