Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Tue, 5 Apr 2016 02:24:25 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12933918.1453751046000.134065.1459823065549@Atlassian.JIRA>
In-Reply-To: <JIRA.12933918.1453751046000@Atlassian.JIRA>
References: <JIRA.12933918.1453751046000@Atlassian.JIRA>
 <JIRA.12933918.1453751046619@arcas>
Subject: [jira] [Commented] (PHOENIX-2628) Ensure split when iterating
 through results handled correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225539#comment-15225539 ] 

ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58478944
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
    @@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final byte[] originalStartKey, final byte[]
             if (scanStopKey.length > 0 && Bytes.compareTo(scanStartKey, scanStopKey) >= 0) { 
                 return null; 
             }
    -        newScan.setAttribute(SCAN_ACTUAL_START_ROW, scanStartKey);
    -        newScan.setStartRow(scanStartKey);
    -        newScan.setStopRow(scanStopKey);
    +        if(ScanUtil.isLocalIndex(scan)) {
    --- End diff --
    
    The code in this if statement can go in the if (keyOffset > 0) if statement instead. We're trying to avoid checks for local indexes. 


> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
>                 Key: PHOENIX-2628
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2628
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch, PHOENIX-2628_v7.patch, PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for scans and aggregates.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)