Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Thu, 7 Apr 2016 23:26:25 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12922550.1450308603000.169540.1460071585696@Atlassian.JIRA>
In-Reply-To: <JIRA.12922550.1450308603000@Atlassian.JIRA>
References: <JIRA.12922550.1450308603000@Atlassian.JIRA>
 <JIRA.12922550.1450308603169@arcas>
Subject: [jira] [Commented] (PHOENIX-2535) Create shaded clients (thin +
 thick)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231328#comment-15231328 ] 

Hadoop QA commented on PHOENIX-2535:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12797621/PHOENIX-2535-5.patch
  against master branch at commit 1e47821876af8100d5b4bc4dad03168eca7f5652.
  ATTACHMENT ID: 12797621

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:red}-1 javac{color}.  The applied patch generated 247 javac compiler warnings (more than the master's current 81 warnings).

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 25 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+                  <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
+                    implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">
+                    implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">
+                    implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">
+                    implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">
+                  implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">
+                  implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">
+                  implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/296//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/296//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/296//console

This message is automatically generated.

> Create shaded clients (thin + thick) 
> -------------------------------------
>
>                 Key: PHOENIX-2535
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2535
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Sergey Soldatov
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, PHOENIX-2535-3.patch, PHOENIX-2535-4.patch, PHOENIX-2535-5.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency conflicts at the run time. We are seeing more of Phoenix JDBC client being used in Storm topologies and other settings where guava versions become a problem. 
> I think we can do a parallel artifact for the thick client with shaded dependencies and also using shaded hbase. For thin client, maybe shading should be the default since it is new? 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)