Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5189419CBA for ; Mon, 11 Apr 2016 18:14:29 +0000 (UTC) Received: (qmail 30185 invoked by uid 500); 11 Apr 2016 18:14:29 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 30122 invoked by uid 500); 11 Apr 2016 18:14:29 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 30109 invoked by uid 99); 11 Apr 2016 18:14:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 18:14:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B6A79180481 for ; Mon, 11 Apr 2016 18:14:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id tISKkcgpahGT for ; Mon, 11 Apr 2016 18:14:28 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id F40375FB79 for ; Mon, 11 Apr 2016 18:14:26 +0000 (UTC) Received: (qmail 29152 invoked by uid 99); 11 Apr 2016 18:14:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 18:14:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 985842C1F5D for ; Mon, 11 Apr 2016 18:14:25 +0000 (UTC) Date: Mon, 11 Apr 2016 18:14:25 +0000 (UTC) From: "Thomas D'Silva (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-2156) Support drop of column from table with views MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas D'Silva updated PHOENIX-2156: ------------------------------------ Attachment: PHOENIX-2156-v4.patch [~jamestaylor] I need the DROP_METADATA_ATTRIBUTE since I am verifying that the physical index table is dropped if its not shared. I moved the tests that require the attribute to DropMetadataIT. > Support drop of column from table with views > -------------------------------------------- > > Key: PHOENIX-2156 > URL: https://issues.apache.org/jira/browse/PHOENIX-2156 > Project: Phoenix > Issue Type: Sub-task > Reporter: James Taylor > Assignee: Thomas D'Silva > Fix For: 4.8.0 > > Attachments: PHOENIX-2156-v2.patch, PHOENIX-2156-v3.patch, PHOENIX-2156-v4.patch, PHOENIX-2156.patch > > > Much like PHOENIX-1504 allows a column to be added to a base view, we should support dropping a column from a table that has views as well. These seems like a simpler problem: you just need to query for all views with a BASE_COLUMN_COUNT < dropped_column_ordinal_pos, decrement the ordinal positions of columns after that, and drop indexes that reference the column being dropped. -- This message was sent by Atlassian JIRA (v6.3.4#6332)