Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Mon, 4 Apr 2016 20:17:25 +0000 (UTC)
From: "Thomas D'Silva (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12850170.1438235253000.130229.1459801045740@Atlassian.JIRA>
In-Reply-To: <JIRA.12850170.1438235253000@Atlassian.JIRA>
References: <JIRA.12850170.1438235253000@Atlassian.JIRA>
 <JIRA.12850170.1438235253888@arcas>
Subject: [jira] [Updated] (PHOENIX-2156) Support drop of column from table
 with views
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/PHOENIX-2156?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas D'Silva updated PHOENIX-2156:
------------------------------------
    Attachment: PHOENIX-2156-v2.patch

[~samarthjain] [~jamestaylor]=20
I have uploaded a modified patch with the review feedback.

testDropColumnsFromBaseTableWithView drops multiple columns from the base t=
able and verifies these are dropped from the view
testDroppingIndexedColDropsViewIndex drops=C2=A0two columns of a base table=
 that has views with multiple indexes.
I moved tests that are multi-tenant from AlterTableWithViewsIT to AlterMult=
iTenantTableWithViewsIT and made the remaining tests parameterized to run f=
or multitenant/non-multitenant cases.

The ClassNotFoundException can be thrown when we get the PhoenixConnection.=
 I changed it so that its caught in dropIndexes.

{code}
 try {
            connection =3D table.getIndexes().isEmpty() ? null : QueryUtil.=
getConnection(
                env.getConfiguration()).unwrap(PhoenixConnection.class);
        } catch (ClassNotFoundException e) {
        }
{code}

> Support drop of column from table with views
> --------------------------------------------
>
>                 Key: PHOENIX-2156
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2156
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2156-v2.patch, PHOENIX-2156.patch
>
>
> Much like PHOENIX-1504 allows a column to be added to a base view, we sho=
uld support dropping a column from a table that has views as well. These se=
ems like a simpler problem: you just need to query for all views with a BAS=
E_COLUMN_COUNT < dropped_column_ordinal_pos, decrement the ordinal position=
s of columns after that, and drop indexes that reference the column being d=
ropped.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)