Return-Path: 
 <dev-return-28593-apmail-phoenix-dev-archive=phoenix.apache.org@phoenix.apache.org>
X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org
Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 02EE01975E
	for <apmail-phoenix-dev-archive@minotaur.apache.org>;
 Wed, 13 Apr 2016 08:38:29 +0000 (UTC)
Received: (qmail 24107 invoked by uid 500); 13 Apr 2016 08:38:28 -0000
Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org
Received: (qmail 24051 invoked by uid 500); 13 Apr 2016 08:38:28 -0000
Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@phoenix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@phoenix.apache.org>
List-Post: <mailto:dev@phoenix.apache.org>
List-Id: <dev.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list dev@phoenix.apache.org
Received: (qmail 24031 invoked by uid 99); 13 Apr 2016 08:38:28 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2016 08:38:28 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 32F23DFB7C; Wed, 13 Apr 2016 08:38:28 +0000 (UTC)
From: ankitsinghal <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-153-phoenix@git.apache.org>
In-Reply-To: <git-pr-153-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced
 in ph...
Content-Type: text/plain
Message-Id: <20160413083828.32F23DFB7C@git1-us-west.apache.org>
Date: Wed, 13 Apr 2016 08:38:28 +0000 (UTC)

Github user ankitsinghal commented on the pull request:

    https://github.com/apache/phoenix/pull/153#issuecomment-209304973
  
    @JamesRTaylor ,
    
    > There are likely lots of issues if isNamespaceMapping config property changes from true to false, no? 
    
    There will not be any problem if **phoenix.connection.isNamespaceMappingEnabled** is set from true to false unless the system tables are migrated after setting **"phoenix.connection.mapSystemTablesToNamespace"** to true as it will migrate the SYSTEM tables to SYSTEM namespace and it is need to be set at client and server both to have IndexFailure, stats collection to work correctly which directly refers system tables at server. Let me know if name of the properties needs to be change to depict it as server and client side property.
    
    >  Wouldn't existing namespace mapped tables not be found if it was changed from true to false after tables had been created?
    
    Tables mapped will still be accessible. Although old client(<v4.8) will not be able to access tables mapped to namespace
    
    > What would be the purpose of allowing a schema (namespace) to be created if the feature is off?If none, then it's probably best to give an error message if isNamespaceMapping is off and CREATE SCHEMA is used.
    
    Yes, I think we can through exception during CREATE SCHEMA only if the property is not set .
    but other constructs (like USE <SCHEMA>) should still be allowed as mapped tables are accessible even isNamespaceMappingEnabled is set to false.
    
    
    
     
    
    
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---