Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: samarthjain <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-153-phoenix@git.apache.org>
In-Reply-To: <git-pr-153-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced
 in ph...
Content-Type: text/plain
Message-Id: <20160412011013.CF0A3DFA69@git1-us-west.apache.org>
Date: Tue, 12 Apr 2016 01:10:13 +0000 (UTC)

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r59307776
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableKey.java ---
    @@ -26,7 +28,8 @@
         public PTableKey(PName tenantId, String name) {
             Preconditions.checkNotNull(name);
             this.tenantId = tenantId;
    -        this.name = name;
    +        this.name = !name.contains(QueryConstants.NAMESPACE_SEPARATOR) ? name
    --- End diff --
    
    I think we could potentially mask some bug or have it fail later than it should if we do this. We should remove this check altogether.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---