Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: codymarcel <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-157-phoenix@git.apache.org>
In-Reply-To: <git-pr-157-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request: merging latest avatica
Content-Type: text/plain
Message-Id: <20160405153035.A6432DFD5B@git1-us-west.apache.org>
Date: Tue,  5 Apr 2016 15:30:35 +0000 (UTC)

Github user codymarcel commented on the pull request:

    https://github.com/apache/phoenix/pull/157#issuecomment-205858884
  
    General Comments.
    
    1. Please add some unit tests. Especially around the instanceResolver and RulesApplier. We user https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/test/resources/scenario/test_scenario.xml as both test base and doc for supported features.
    2. Formatting needs some work across the board. Make sure you have the formatter for the project applied and your ide is set to convert tabs to spaces.
    3. Remove all code that's in comments. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---