Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56931190FC for ; Tue, 5 Apr 2016 15:10:03 +0000 (UTC) Received: (qmail 33042 invoked by uid 500); 5 Apr 2016 15:10:03 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 32981 invoked by uid 500); 5 Apr 2016 15:10:03 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 32970 invoked by uid 99); 5 Apr 2016 15:10:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 15:10:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D1F50DFAFF; Tue, 5 Apr 2016 15:10:02 +0000 (UTC) From: JamesRTaylor To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau... Content-Type: text/plain Message-Id: <20160405151002.D1F50DFAFF@git1-us-west.apache.org> Date: Tue, 5 Apr 2016 15:10:02 +0000 (UTC) Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/154#issuecomment-205850495 A few minor items, but otherwise it looks good. Nice work, @ankitsinghal! If you could file a JIRA for the corresponding website/doc changes and submit a patch for that when we're closer to the 4.8 release, that'd be much appreciated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---