Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: JamesRTaylor <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-154-phoenix@git.apache.org>
In-Reply-To: <git-pr-154-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request: PHOENIX-2722 support mysql
 limit,offset clau...
Content-Type: text/plain
Message-Id: <20160405150059.55522DFAFF@git1-us-west.apache.org>
Date: Tue,  5 Apr 2016 15:00:59 +0000 (UTC)

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r58553769
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java ---
    @@ -130,9 +135,9 @@ public OrderedResultIterator(ResultIterator delegate, List<OrderByExpression> or
                 SizedUtil.OBJECT_SIZE + estimatedRowSize;
     
             // Make sure we don't overflow Long, though this is really unlikely to happen.
    -        assert(limit == null || Long.MAX_VALUE / estimatedEntrySize >= limit);
    +        assert (limit == null || Long.MAX_VALUE / estimatedEntrySize >= limit + this.offset);
    --- End diff --
    
    Based on the above diff, you added a space after "assert". Please remove so our formatting is consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---