Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: ankitsinghal <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-154-phoenix@git.apache.org>
In-Reply-To: <git-pr-154-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request: PHOENIX-2722 support mysql
 limit,offset clau...
Content-Type: text/plain
Message-Id: <20160405091609.613E1DFCDF@git1-us-west.apache.org>
Date: Tue,  5 Apr 2016 09:16:09 +0000 (UTC)

Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r58506510
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/MergeSortTopNResultIterator.java ---
    @@ -79,9 +86,11 @@ public Tuple peek() throws SQLException {
     
         @Override
         public Tuple next() throws SQLException {
    -        if (limit >= 0 && count++ >= limit) {
    -            return null;
    +        while (count < offset) {
    +            if (super.next() == null) { return null; }
    +            count++;
             }
    +        if (limit >= 0 && count++ >= limit) { return null; }
    --- End diff --
    
    Actually it should count++ only, but there is a bug in offset count .. which I have updated now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---