Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: ankitsinghal <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-154-phoenix@git.apache.org>
In-Reply-To: <git-pr-154-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request: PHOENIX-2722 support mysql
 limit,offset clau...
Content-Type: text/plain
Message-Id: <20160405084832.CB9A9DFC6E@git1-us-west.apache.org>
Date: Tue,  5 Apr 2016 08:48:32 +0000 (UTC)

Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r58504649
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
    @@ -168,7 +169,11 @@ public QueryPlan compileUnionAll(SelectStatement select) throws SQLException {
                 SelectStatement subSelect = unionAllSelects.get(i);
                 // Push down order-by and limit into sub-selects.
                 if (!select.getOrderBy().isEmpty() || select.getLimit() != null) {
    -                subSelect = NODE_FACTORY.select(subSelect, select.getOrderBy(), select.getLimit());
    +                if (select.getOffset() == null) {
    +                    subSelect = NODE_FACTORY.select(subSelect, select.getOrderBy(), select.getLimit(), null);
    +                } else {
    +                    subSelect = NODE_FACTORY.select(subSelect, select.getOrderBy(), null, null);
    +                }
    --- End diff --
    
    Actually , In case of union , we need to apply offset at the final result so we can't apply limit or offset in subselect.
    but, if offset is not present , limit can be applied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---