phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "churro morales (JIRA)" <>
Subject [jira] [Reopened] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
Date Mon, 11 Apr 2016 23:37:25 GMT


churro morales reopened PHOENIX-2822:

some tests break due to shared state.

> Tests that extend BaseHBaseManagedTimeIT are very slow
> ------------------------------------------------------
>                 Key: PHOENIX-2822
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.8.0
>            Reporter: churro morales
>            Assignee: churro morales
>              Labels: HBASEDEPENDENCIES
>         Attachments: PHOENIX-2822-98.patch, PHOENIX-2822.patch
> Since I am trying to refactor out all the hbase private dependencies, I have to constantly
run tests to make sure I didn't break anything.  The tests that extend BaseHBaseManagedTimeIT
are very slow as they have to delete all non-system tables after every test case.  This takes
around 5-10 seconds to accomplish.  This adds significant time to the test suite. 
> I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates a random
table name such that we dont have collisions for tests.  It also doesn't do any cleanup after
each test case or class because these table names should be unique.  I moved about 30-35 tests
out from BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it significantly improved
the overall time it takes to run tests.

This message was sent by Atlassian JIRA

View raw message