phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
Date Wed, 06 Apr 2016 07:10:25 GMT


ASF GitHub Bot commented on PHOENIX-2822:

Github user JamesRTaylor commented on a diff in the pull request:
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/
    @@ -43,9 +44,10 @@ public void initTable() throws Exception {
             Connection conn = null;
             PreparedStatement stmt = null;
             try {
    +            System.out.println("TABLE_NAME = " + TABLE_NAME);
    --- End diff --
    Minor nit - remove this.

> Tests that extend BaseHBaseManagedTimeIT are very slow
> ------------------------------------------------------
>                 Key: PHOENIX-2822
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.8.0
>            Reporter: churro morales
>            Assignee: churro morales
>              Labels: HBASEDEPENDENCIES
> Since I am trying to refactor out all the hbase private dependencies, I have to constantly
run tests to make sure I didn't break anything.  The tests that extend BaseHBaseManagedTimeIT
are very slow as they have to delete all non-system tables after every test case.  This takes
around 5-10 seconds to accomplish.  This adds significant time to the test suite. 
> I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates a random
table name such that we dont have collisions for tests.  It also doesn't do any cleanup after
each test case or class because these table names should be unique.  I moved about 30-35 tests
out from BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it significantly improved
the overall time it takes to run tests.

This message was sent by Atlassian JIRA

View raw message