phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
Date Tue, 05 Apr 2016 19:49:25 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227000#comment-15227000
] 

ASF GitHub Bot commented on PHOENIX-2822:
-----------------------------------------

GitHub user churrodog opened a pull request:

    https://github.com/apache/phoenix/pull/158

    PHOENIX-2822 - Tests that extend BaseHBaseManagedTimeIT are very slow

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/churrodog/phoenix PHOENIX-2822

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #158
    
----
commit 8325d00cd01b2a7d71b52b7c6d0ff5f6147ba47a
Author: rahul gidwani <rgidwani@salesforce.com>
Date:   2016-04-05T19:38:21Z

    PHOENIX-2822 - Tests that extend BaseHBaseManagedTimeIT are very slow
    
    Conflicts:
    	phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java

----


> Tests that extend BaseHBaseManagedTimeIT are very slow
> ------------------------------------------------------
>
>                 Key: PHOENIX-2822
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2822
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.8.0
>            Reporter: churro morales
>            Assignee: churro morales
>              Labels: HBASEDEPENDENCIES
>
> Since I am trying to refactor out all the hbase private dependencies, I have to constantly
run tests to make sure I didn't break anything.  The tests that extend BaseHBaseManagedTimeIT
are very slow as they have to delete all non-system tables after every test case.  This takes
around 5-10 seconds to accomplish.  This adds significant time to the test suite. 
> I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates a random
table name such that we dont have collisions for tests.  It also doesn't do any cleanup after
each test case or class because these table names should be unique.  I moved about 30-35 tests
out from BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it significantly improved
the overall time it takes to run tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message