phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maryann Xue (JIRA)" <j...@apache.org>
Subject [jira] [Created] (PHOENIX-2819) Remove problematic method ValueSchemaBuilder.addField(Field)
Date Sun, 03 Apr 2016 17:32:25 GMT
Maryann Xue created PHOENIX-2819:
------------------------------------

             Summary: Remove problematic method ValueSchemaBuilder.addField(Field)
                 Key: PHOENIX-2819
                 URL: https://issues.apache.org/jira/browse/PHOENIX-2819
             Project: Phoenix
          Issue Type: Bug
    Affects Versions: 4.7.0
            Reporter: Maryann Xue
            Assignee: Maryann Xue
             Fix For: 4.8.0


We should discard the method "ValueSchemaBuilder.addField(Field)" and use the other method
signature instead, since this method might add more fields than wanted.
{code}
        public ValueSchemaBuilder addField(Field field) {
            fields.add(field);
            return this;
        }
{code}
If {{field.size}} is larger than 1, the above statement {{fields.add(field)}} will add more
than one field into the list while the caller is expecting to add only ONE.
The only caller of this method is IndexMaintainer.generateIndexRowKeySchema() and it might
generate a wrong row-key-schema as a result.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message