phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2810) Fixing IndexTool Dependencies
Date Thu, 07 Apr 2016 08:25:25 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229896#comment-15229896
] 

Gabriel Reid commented on PHOENIX-2810:
---------------------------------------

Sorry I took so long to take a look at this.

The patch doesn't work on the HBase 0.98 version, because things like Connection and RegionLocator
didn't exist in HBase 0.98, and isn't directly compatible with the HBase 1.0 version because
it makes use of a new overload of LoadIncrementalHFiles.doBulkLoad that isn't available in
1.0.

I'm no longer sure what the plan is for supporting 0.98 and 1.0 in terms of future releases,
but I think it might be better to hold off on making this change until then. It's basically
a cosmetic change for now anyway (the deprecated HFileOutputFormat simply delegates everything
to HFileOutputFormat2), so while we'd be getting rid of the deprecation warning, we'd be adding
in extra unnecessary differences between branches without a real advantage I think.

> Fixing IndexTool Dependencies
> -----------------------------
>
>                 Key: PHOENIX-2810
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2810
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: churro morales
>            Priority: Minor
>              Labels: HBASEDEPENDENCIES
>         Attachments: PHOENIX-2810.patch
>
>
> IndexTool uses HFileOutputFormat which is deprecated.  Use HFileOutputFormat2 instead
and fix other private dependencies for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message