phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-2743) HivePhoenixHandler for big-big join with predicate push down
Date Mon, 11 Apr 2016 20:22:26 GMT


ASF GitHub Bot commented on PHOENIX-2743:

Github user joshelser commented on the pull request:
    Some general thoughts (I stopped leaving them inline everytime I saw them). I'm guessing
you "inherited" some of these from JeongMin's original work.
    * Dbl-check indentations
    * Try to remove commented out code
    * Some class-level javadoc comments would be *amazing*
    * Not a single unit test? :)
    Other things that I remember biting me previously:
    * Make sure you try to run with Tez as well. Both in the "uber" (local job) mode and a
normal tez task. There are.. subtleties between them, sadly (as sadly, I don't remember the
specifics anymore).
    Other general thoughts:
    * The RecordUpdater implementation looks pretty cool. Didn't know they made this available
for StorageHandlers.
    * Hive has a decent suite for running Hive tests as a part of their build (which includes
tests for StorageHandlers) with this qtest/itest modules. You might be able to take some inspiration
from these for testing.
    Looks good so far. It will be a nice bridge between Phoenix and Hive (as we work towards
a common-core of Calcite).

> HivePhoenixHandler for big-big join with predicate push down
> ------------------------------------------------------------
>                 Key: PHOENIX-2743
>                 URL:
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.5.0, 4.6.0
>         Environment: hive-1.2.1
>            Reporter: JeongMin Ju
>              Labels: features, performance
>         Attachments: PHOENIX-2743-1.patch
>   Original Estimate: 168h
>  Remaining Estimate: 168h
> Phoenix support hash join & sort-merge join. But in case of big*big join does not
process well.
> Therefore Need other method like Hive.
> I implemented hive-phoenix-handler that can access Apache Phoenix table on HBase using
> hive-phoenix-handler is very faster than hive-hbase-handler because of applying predicate
push down.
> I am publishing source code to github for contribution and maybe will be completed by
next week.
> please, review my proposal.

This message was sent by Atlassian JIRA

View raw message