phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly
Date Wed, 06 Apr 2016 01:27:25 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227514#comment-15227514
] 

ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------

Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58640276
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
    @@ -121,8 +170,21 @@ public synchronized void initScanner() throws SQLException {
                     this.scanIterator =
                             new ScanningResultIterator(htable.getScanner(scan), scanMetrics);
                 } catch (IOException e) {
    -                Closeables.closeQuietly(htable);
    -                throw ServerUtil.parseServerException(e);
    +                if(handleSplitRegionBoundaryFailureDuringInitialization) {
    --- End diff --
    
    This is required for ChunkedResultIterator if we are going to deprecate or not use it
we don't need these changes. Other than that we might need to deal with it in PhoenixRecordReader(currently
we skipping range check but for local indexes it's compulsory to handle otherwise we might
miss one of the daughter records)


> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
>                 Key: PHOENIX-2628
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2628
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch, PHOENIX-2628_v7.patch,
PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for scans and aggregates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message