phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly
Date Tue, 05 Apr 2016 04:21:25 GMT


ASF GitHub Bot commented on PHOENIX-2628:

Github user JamesRTaylor commented on the pull request:
    Thanks for the patch, @chrajeshbabu. This is a big improvement over your initial approach.
It's still complex, though. There's an on going cost to complicating the code to this degree
that would be good to minimize. 
    One big thing missing is an overview of all the moving parts. Perhaps that could live
in BaseResultIterators? For example - this exception is thrown under these conditions and
this state is added to the scan to know how to adjust the scan ranges, etc. etc. Especially
that hasReferences bit in the coprocessor - what's that all about?
    I'd like to understand how ChunkedResultIterator complicates things too. I think it'd
be ok to document that splits during aggregate queries aren't handled if your HBase version
is less that XXX if it'd significantly simplify this patch (as that code is essentially deprecated).

    Another potential, different approach would be for Phoenix to universally handle the split
during scan case (rather than letting the HBase client scanner handle it for non aggregate
case and Phoenix handle it for the aggregate case). Would that simplify things?

> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>                 Key: PHOENIX-2628
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.8.0
>         Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch, PHOENIX-2628_v7.patch,
> We should start with a test case to ensure this works correctly, both for scans and aggregates.

This message was sent by Atlassian JIRA

View raw message