phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly
Date Tue, 05 Apr 2016 03:08:25 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225574#comment-15225574
] 

ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58481362
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
    @@ -337,6 +384,22 @@ public boolean nextRaw(List<Cell> result) throws IOException
{
                             arrayElementCell = result.get(arrayElementCellPosition);
                         }
                         if (ScanUtil.isLocalIndex(scan) && !ScanUtil.isAnalyzeTable(scan))
{
    +                        if(hasReferences && actualStartKey!=null) {
    +                            Cell firstCell = result.get(0);
    +                            while(Bytes.compareTo(firstCell.getRowArray(), firstCell.getRowOffset(),
firstCell.getRowLength(), actualStartKey, 0, actualStartKey.length)<0) {
    +                                result.clear();
    +                                next = s.nextRaw(result);
    +                                if (result.isEmpty()) {
    +                                    return next;
    +                                }
    +                                if (arrayFuncRefs != null && arrayFuncRefs.length
> 0 && arrayKVRefs.size() > 0) {
    +                                    replaceArrayIndexElement(arrayKVRefs, arrayFuncRefs,
result);
    +                                }
    +                                firstCell = result.get(0);
    +                            }
    +                        }
    +                        System.out.println("&&&&-< "+scan);
    +                        System.out.println("&&&&-<< "+result);
    --- End diff --
    
    Remove System.out.println calls


> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
>                 Key: PHOENIX-2628
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2628
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch, PHOENIX-2628_v7.patch,
PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for scans and aggregates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message