phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix
Date Tue, 12 Apr 2016 01:09:25 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236385#comment-15236385
] 

ASF GitHub Bot commented on PHOENIX-1311:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r59307651
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
    @@ -1279,4 +1304,129 @@ public static boolean truncateStats(HTableInterface metaTable,
HTableInterface s
             }
             return false;
         }
    +
    +    public static void mapTableToNamespace(HBaseAdmin admin, HTableInterface metatable,
String srcTableName,
    +            String destTableName, ReadOnlyProps props, Long ts, String phoenixTableName,
PTableType pTableType)
    +                    throws SnapshotCreationException, IllegalArgumentException, IOException,
InterruptedException,
    +                    SQLException {
    +        srcTableName = SchemaUtil.normalizeIdentifier(srcTableName);
    +        if (!SchemaUtil.isNamespaceMappingEnabled(
    +                SchemaUtil.isSystemTable(srcTableName.getBytes()) ? PTableType.SYSTEM
: null,
    +                props)) { throw new IllegalArgumentException(SchemaUtil.isSystemTable(srcTableName.getBytes())
    +                        ? "For system table " + QueryServices.IS_SYSTEM_TABLE_MAPPED_TO_NAMESPACE
    +                                + " also needs to be enabled along with " + QueryServices.IS_NAMESPACE_MAPPING_ENABLED
    +                        : QueryServices.IS_NAMESPACE_MAPPING_ENABLED + " is not enabled");
}
    +
    +        if (PTableType.TABLE.equals(pTableType) || PTableType.INDEX.equals(pTableType))
{
    +            admin.snapshot(srcTableName, srcTableName);
    +            admin.cloneSnapshot(srcTableName.getBytes(), destTableName.getBytes());
    +            admin.disableTable(srcTableName);
    --- End diff --
    
    Sounds like we would leaving snapshots dangling around. We should remove snapshots once
we have successfully upgraded the table. If the user wants to be cautious he/she can always
snapshot their table/s first before running this upgrade. In case of failure, we should try
restoring the table/s using the snapshot that Phoenix has taken and attempt to delete  the
snapshot after the attempt. We should try and not leavE any residual state from the upgrade,
IMHO.


> HBase namespaces surfaced in phoenix
> ------------------------------------
>
>                 Key: PHOENIX-1311
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1311
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: nicolas maillard
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch, PHOENIX-1311_v2.patch,
PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of myNamespace:MyTable it
would be great if Phoenix leveraged this feature to give a database like feature on top of
the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message