phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ankitsinghal <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...
Date Wed, 13 Apr 2016 08:38:28 GMT
Github user ankitsinghal commented on the pull request:

    https://github.com/apache/phoenix/pull/153#issuecomment-209304973
  
    @JamesRTaylor ,
    
    > There are likely lots of issues if isNamespaceMapping config property changes from
true to false, no? 
    
    There will not be any problem if **phoenix.connection.isNamespaceMappingEnabled** is set
from true to false unless the system tables are migrated after setting **"phoenix.connection.mapSystemTablesToNamespace"**
to true as it will migrate the SYSTEM tables to SYSTEM namespace and it is need to be set
at client and server both to have IndexFailure, stats collection to work correctly which directly
refers system tables at server. Let me know if name of the properties needs to be change to
depict it as server and client side property.
    
    >  Wouldn't existing namespace mapped tables not be found if it was changed from true
to false after tables had been created?
    
    Tables mapped will still be accessible. Although old client(<v4.8) will not be able
to access tables mapped to namespace
    
    > What would be the purpose of allowing a schema (namespace) to be created if the feature
is off?If none, then it's probably best to give an error message if isNamespaceMapping is
off and CREATE SCHEMA is used.
    
    Yes, I think we can through exception during CREATE SCHEMA only if the property is not
set .
    but other constructs (like USE <SCHEMA>) should still be allowed as mapped tables
are accessible even isNamespaceMappingEnabled is set to false.
    
    
    
     
    
    
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message