phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samarthjain <>
Subject [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...
Date Tue, 12 Apr 2016 01:10:13 GMT
Github user samarthjain commented on a diff in the pull request:
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/ ---
    @@ -26,7 +28,8 @@
         public PTableKey(PName tenantId, String name) {
             this.tenantId = tenantId;
    - = name;
    + = !name.contains(QueryConstants.NAMESPACE_SEPARATOR) ? name
    --- End diff --
    I think we could potentially mask some bug or have it fail later than it should if we
do this. We should remove this check altogether.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message