phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samarthjain <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...
Date Tue, 12 Apr 2016 01:08:26 GMT
Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r59307651
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
    @@ -1279,4 +1304,129 @@ public static boolean truncateStats(HTableInterface metaTable,
HTableInterface s
             }
             return false;
         }
    +
    +    public static void mapTableToNamespace(HBaseAdmin admin, HTableInterface metatable,
String srcTableName,
    +            String destTableName, ReadOnlyProps props, Long ts, String phoenixTableName,
PTableType pTableType)
    +                    throws SnapshotCreationException, IllegalArgumentException, IOException,
InterruptedException,
    +                    SQLException {
    +        srcTableName = SchemaUtil.normalizeIdentifier(srcTableName);
    +        if (!SchemaUtil.isNamespaceMappingEnabled(
    +                SchemaUtil.isSystemTable(srcTableName.getBytes()) ? PTableType.SYSTEM
: null,
    +                props)) { throw new IllegalArgumentException(SchemaUtil.isSystemTable(srcTableName.getBytes())
    +                        ? "For system table " + QueryServices.IS_SYSTEM_TABLE_MAPPED_TO_NAMESPACE
    +                                + " also needs to be enabled along with " + QueryServices.IS_NAMESPACE_MAPPING_ENABLED
    +                        : QueryServices.IS_NAMESPACE_MAPPING_ENABLED + " is not enabled");
}
    +
    +        if (PTableType.TABLE.equals(pTableType) || PTableType.INDEX.equals(pTableType))
{
    +            admin.snapshot(srcTableName, srcTableName);
    +            admin.cloneSnapshot(srcTableName.getBytes(), destTableName.getBytes());
    +            admin.disableTable(srcTableName);
    --- End diff --
    
    Sounds like we would leaving snapshots dangling around. We should remove snapshots once
we have successfully upgraded the table. If the user wants to be cautious he/she can always
snapshot their table/s first before running this upgrade. In case of failure, we should try
restoring the table/s using the snapshot that Phoenix has taken and attempt to delete  the
snapshot after the attempt. We should try and not leavE any residual state from the upgrade,
IMHO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message